Transaction is already completed - do not call commit or rollback more than once per transaction

刺骨的言语ヽ痛彻心扉 2023-07-19 10:38 24阅读 0赞

## 问题 ##

19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceTransactionManager: Creating new transaction with name [ChansonTransaction]: PROPAGATION_REQUIRES_NEW,ISOLATION_READ_COMMITTED
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceTransactionManager: Acquired Connection [jdbc:mysql://localhost:3306/test1?useUnicode=true&characterEncoding=UTF-8&useSSL=false, UserName=root@localhost, MySQL Connector Java] for JDBC transaction
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceUtils: Changing isolation level of JDBC Connection [jdbc:mysql://localhost:3306/test1?useUnicode=true&characterEncoding=UTF-8&useSSL=false, UserName=root@localhost, MySQL Connector Java] to 2
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceTransactionManager: Switching JDBC Connection [jdbc:mysql://localhost:3306/test1?useUnicode=true&characterEncoding=UTF-8&useSSL=false, UserName=root@localhost, MySQL Connector Java] to manual commit
    19/01/29 14:41:31 [main]: DEBUG core.JdbcTemplate: Executing prepared SQL update
    19/01/29 14:41:31 [main]: DEBUG core.JdbcTemplate: Executing prepared SQL statement [UPDATE t_user SET password=? WHERE user_name =?]
    19/01/29 14:41:31 [main]: DEBUG core.JdbcTemplate: SQL update affected 1 rows
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceTransactionManager: Initiating transaction rollback
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceTransactionManager: Rolling back JDBC transaction on Connection [jdbc:mysql://localhost:3306/test1?useUnicode=true&characterEncoding=UTF-8&useSSL=false, UserName=root@localhost, MySQL Connector Java]
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceUtils: Resetting isolation level of JDBC Connection [jdbc:mysql://localhost:3306/test1?useUnicode=true&characterEncoding=UTF-8&useSSL=false, UserName=root@localhost, MySQL Connector Java] to 4
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceTransactionManager: Releasing JDBC Connection [jdbc:mysql://localhost:3306/test1?useUnicode=true&characterEncoding=UTF-8&useSSL=false, UserName=root@localhost, MySQL Connector Java] after transaction
    19/01/29 14:41:31 [main]: DEBUG datasource.DataSourceUtils: Returning JDBC Connection to DataSource
    Exception in thread "main" org.springframework.transaction.IllegalTransactionStateException: Transaction is already completed - do not call commit or rollback more than once per transaction
    	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:697)
    	at springjiemi.platformtransaction.UserService.update(UserService.java:42)
    	at springjiemi.platformtransaction.UserService.main(UserService.java:50)

## 分析 ##

日志显示存在事务多次提交的问题。

分析了一下源代码：

public void read() { 
    
            //手动开启事务
            TransactionStatus transactionStatus = dataSourceTransactionManager.getTransaction(transactionDefinition);
    
            try { 
                int i=1/0;
            } catch (Exception e) { 
                //手动回滚事务
                dataSourceTransactionManager.rollback(transactionStatus);
            }
    
            //手动提交事务
            dataSourceTransactionManager.commit(transactionStatus);//提交
    
    
        }

由于异常被`catch`，而在`catch`时，`进行了事务回滚`，`正常在此应该退出方法处理（程序直接返回或者抛出异常），但事实上程序直接执行了后续的代码：dataSourceTransactionManager.commit(transactionStatus);`所以报错。

## 解决 ##

解决方法：在catch过程中，抛出异常，结束方法执行。

public void read() { 
    
            //手动开启事务
            TransactionStatus transactionStatus = dataSourceTransactionManager.getTransaction(transactionDefinition);
    
            try { 
                int i=1/0;
            } catch (Exception e) { 
                //手动回滚事务
                dataSourceTransactionManager.rollback(transactionStatus);
                throw e;
            }
    
            //手动提交事务
            dataSourceTransactionManager.commit(transactionStatus);//提交
    
    
        }